From 9dd27bb4e5261c49a9db88adb408cb90d7864244 Mon Sep 17 00:00:00 2001
From: cogwheel0 <172976095+cogwheel0@users.noreply.github.com>
Date: Sun, 5 Oct 2025 23:43:50 +0530
Subject: [PATCH] refactor: streamline handling of <details> tags in markdown
 parsing

- Updated the assistant message widget to rely on the markdown parser for <details> tags, eliminating manual tag management for tool_calls and reasoning types.
- Enhanced the details builder to ensure proper handling of <details> elements during streaming, preventing character flashing.
- Cleaned up the code by removing redundant comments and consolidating logic for improved readability and maintainability.
---
 .../widgets/assistant_message_widget.dart     | 32 +++++--------------
 .../widgets/markdown/markdown_config.dart     |  8 +++--
 2 files changed, 13 insertions(+), 27 deletions(-)

diff --git a/lib/features/chat/widgets/assistant_message_widget.dart b/lib/features/chat/widgets/assistant_message_widget.dart
index 1a614be..b6bc8d5 100644
--- a/lib/features/chat/widgets/assistant_message_widget.dart
+++ b/lib/features/chat/widgets/assistant_message_widget.dart
@@ -720,26 +720,14 @@ class _AssistantMessageWidgetState extends ConsumerState<AssistantMessageWidget>
       return const SizedBox.shrink();
     }
 
-    // Always hide tool_calls blocks; tiles render them separately.
-    String cleaned = content.replaceAll(
-      RegExp(
-        r'<details\s+type="tool_calls"[^>]*>[\s\S]*?<\/details>',
-        multiLine: true,
-        dotAll: true,
-      ),
-      '',
-    );
-    // Also hide reasoning details blocks if any slipped into text
-    cleaned = cleaned.replaceAll(
-      RegExp(
-        r'<details\s+type="reasoning"[^>]*>[\s\S]*?<\/details>',
-        multiLine: true,
-        dotAll: true,
-      ),
-      '',
-    );
-    // Remove raw <think>...</think> or <reasoning>...</reasoning> tags in text
-    cleaned = cleaned
+    // Note: The markdown parser now handles <details> tags (including type="reasoning"
+    // and type="tool_calls") via a custom block syntax, so they won't be rendered as
+    // plain text during streaming. This prevents character flashing.
+
+    // We still clean raw reasoning tags (<think>, <reasoning>) as a fallback.
+    // The server normally converts these to <details> format, but raw mode or
+    // direct API responses might still use them.
+    String cleaned = content
         .replaceAll(
           RegExp(r'<think>[\s\S]*?<\/think>', multiLine: true, dotAll: true),
           '',
@@ -753,10 +741,6 @@ class _AssistantMessageWidgetState extends ConsumerState<AssistantMessageWidget>
           '',
         );
 
-    // Note: The markdown parser now handles <details> tags via a custom block syntax,
-    // so they won't be rendered as plain text during streaming. This prevents the
-    // character flashing issue.
-
     // Process images in the remaining text
     final processedContent = _processContentForImages(cleaned);
 
diff --git a/lib/shared/widgets/markdown/markdown_config.dart b/lib/shared/widgets/markdown/markdown_config.dart
index 6a974d9..42ec6cd 100644
--- a/lib/shared/widgets/markdown/markdown_config.dart
+++ b/lib/shared/widgets/markdown/markdown_config.dart
@@ -763,9 +763,11 @@ class _DetailsBuilder extends MarkdownElementBuilder {
 
   @override
   Widget? visitElementAfter(md.Element element, TextStyle? preferredStyle) {
-    // The details element should not be rendered as markdown during streaming.
-    // Instead, it's handled by the ReasoningParser in assistant_message_widget.
-    // Return empty widget to prevent flashing.
+    // Details elements with type="reasoning" or type="tool_calls" should not be
+    // rendered as markdown during streaming. They are handled by:
+    // - ReasoningParser for reasoning blocks (creates thinking tiles)
+    // - ToolCallsParser for tool_calls blocks (creates tool execution tiles)
+    // Return empty widget to prevent character flashing during streaming.
     return const SizedBox.shrink();
   }
 }